From: Ján Tomko Date: Fri, 6 Mar 2015 16:09:49 +0000 (+0100) Subject: Use virBitmapNextClearBit in networkNextClassID X-Git-Tag: v1.2.14-rc1~224 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7b2f12fe28edb011e834fbf083c62c44e04d4f24;p=thirdparty%2Flibvirt.git Use virBitmapNextClearBit in networkNextClassID Instead of finding the next clear bit by calling virBitmapGetBit in a loop, use the virBitmapNextClearBit helper. --- diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 9637371c32..5752acb214 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -4672,13 +4672,11 @@ networkCheckBandwidth(virNetworkObjPtr net, static ssize_t networkNextClassID(virNetworkObjPtr net) { - size_t ret = 0; - bool is_set = false; + ssize_t ret = 0; - while (virBitmapGetBit(net->class_id, ret, &is_set) == 0 && is_set) - ret++; + ret = virBitmapNextClearBit(net->class_id, -1); - if (is_set || virBitmapSetBit(net->class_id, ret) < 0) + if (ret < 0 || virBitmapSetBit(net->class_id, ret) < 0) return -1; return ret;