From: Petr Machata <pmachata@redhat.com>
Date: Mon, 30 Mar 2009 17:43:46 +0000 (+0200)
Subject: dwarflint: DW_FORM_ref_addr doesn't have to be relocated
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7b7e22db838c180520937a7cf1d75f8384e40cc5;p=thirdparty%2Felfutils.git

dwarflint: DW_FORM_ref_addr doesn't have to be relocated
---

diff --git a/src/dwarflint.c b/src/dwarflint.c
index 07e30bc75..4cea78deb 100644
--- a/src/dwarflint.c
+++ b/src/dwarflint.c
@@ -3165,9 +3165,11 @@ read_die_chain (struct read_ctx *ctx,
 					    &where, skip_mismatched)))
 		  relocate_one (reloc, rel, addr_64 ? 8 : 4, &addr, &where,
 				reloc_target (form, it), NULL);
-		else if ((type_is_rel
-			  || form == DW_FORM_ref_addr)
-			 && addr != 0)
+		else if (type_is_rel && addr != 0)
+		  /* In non-rel files, neither addr, nor ref_addr
+		     /need/ a relocation.  We at least check that
+		     ref_addr points to sensible datum by recording
+		     the reference below.  */
 		  wr_message (mc_impact_2 | mc_die_rel | mc_reloc, &where,
 			      PRI_LACK_RELOCATION, dwarf_form_string (form));