From: Alexander Marx <amarx@ipfire.org>
Date: Fri, 8 Nov 2013 12:40:24 +0000 (+0100)
Subject: Firewall: Bugfix: When creating a rule and using brackets in comment, the rule is... 
X-Git-Tag: v2.15-beta1~163
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7b82bee7c4886652ef64f639fd877daa727d1348;p=ipfire-2.x.git

Firewall: Bugfix: When creating a rule and using brackets in comment, the rule is denied because of invalid characters in String. But when creating a rule with just valid characters (witjout brackets) and then editing the rule it is possible to use brackets without errormessage.
Now brackets are allowed.
---

diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
index 0b7c6fc444..3e4e3b0eb7 100755
--- a/html/cgi-bin/firewall.cgi
+++ b/html/cgi-bin/firewall.cgi
@@ -2355,7 +2355,7 @@ sub validremark
 	if ($remark !~ /^[a-zäöüA-ZÖÄÜ0-9-.:;\|_()\/\s]*$/) {
 		return 0;}
 	# First character can only be a letter or a digit
-	if (substr ($remark, 0, 1) !~ /^[a-zäöüA-ZÖÄÜ0-9]*$/) {
+	if (substr ($remark, 0, 1) !~ /^[a-zäöüA-ZÖÄÜ0-9(]*$/) {
 		return 0;}
 	# Last character can only be a letter or a digit
 	if (substr ($remark, -1, 1) !~ /^[a-zöäüA-ZÖÄÜ0-9.:;_)]*$/) {