From: Tom Lane Date: Fri, 9 May 2008 22:38:05 +0000 (+0000) Subject: Fix an ancient oversight in change_varattnos_of_a_node: it neglected to update X-Git-Tag: REL7_4_20~9 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7baef60c8b6b178f43379810b1cb89664905208a;p=thirdparty%2Fpostgresql.git Fix an ancient oversight in change_varattnos_of_a_node: it neglected to update varoattno along with varattno. This resulted in having Vars that were not seen as equal(), causing inheritance of the "same" constraint from different parent relations to fail. An example is create table pp1 (f1 int check (f1>0)); create table cc1 (f2 text, f3 int) inherits (pp1); create table cc2(f4 float) inherits(pp1,cc1); Backpatch as far as 7.4. (The test case still fails in 7.4, for reasons that I don't feel like investigating at the moment.) This is a backpatch commit only. The fix will be applied in HEAD as part of the upcoming pg_constraint patch. --- diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 7bd8cbe8ffd..97caafbb8e1 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.91.2.2 2004/11/17 00:18:23 neilc Exp $ + * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.91.2.3 2008/05/09 22:38:05 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -877,7 +877,7 @@ change_varattnos_walker(Node *node, const AttrNumber *newattno) * such a node currently. */ Assert(newattno[var->varattno - 1] > 0); - var->varattno = newattno[var->varattno - 1]; + var->varattno = var->varoattno = newattno[var->varattno - 1]; } return false; }