From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Fri, 17 Mar 2017 09:28:02 +0000 (+0400)
Subject: vnc: fix a qio-channel leak
X-Git-Tag: v2.9.0-rc1~10^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7bc4f0846f5e15dad5a54490290241243b5a4416;p=thirdparty%2Fqemu.git

vnc: fix a qio-channel leak

Spotted by ASAN.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20170317092802.17973-1-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---

diff --git a/ui/vnc.c b/ui/vnc.c
index 8bfb1e0685d..6e93b883b54 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3677,6 +3677,7 @@ static int vnc_display_listen_addr(VncDisplay *vd,
         qio_channel_set_name(QIO_CHANNEL(sioc), name);
         if (qio_channel_socket_listen_sync(
                 sioc, rawaddrs[i], listenerr == NULL ? &listenerr : NULL) < 0) {
+            object_unref(OBJECT(sioc));
             continue;
         }
         listening = true;