From: Itagaki Takahiro <itagaki.takahiro@gmail.com>
Date: Wed, 9 Jun 2010 00:59:54 +0000 (+0000)
Subject: Fix connection leak in dblink when dblink_connect() or dblink_connect_u()
X-Git-Tag: REL8_2_18~51
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7bd31c67150191e0261c96d8870587e5b294e50f;p=thirdparty%2Fpostgresql.git

Fix connection leak in dblink when dblink_connect() or dblink_connect_u()
end with "duplicate connection name" errors.

Backported to release 7.4.
---

diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index bbe40060a2f..e5db663ec43 100644
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -8,7 +8,7 @@
  * Darko Prenosil <Darko.Prenosil@finteh.hr>
  * Shridhar Daithankar <shridhar_daithankar@persistent.co.in>
  *
- * $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.60.2.6 2010/06/03 09:43:04 itagaki Exp $
+ * $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.60.2.7 2010/06/09 00:59:54 itagaki Exp $
  * Copyright (c) 2001-2006, PostgreSQL Global Development Group
  * ALL RIGHTS RESERVED;
  *
@@ -2287,9 +2287,14 @@ createNewConnection(const char *name, remoteConn * rconn)
 											   HASH_ENTER, &found);
 
 	if (found)
+	{
+		PQfinish(rconn->conn);
+		pfree(rconn);
+
 		ereport(ERROR,
 				(errcode(ERRCODE_DUPLICATE_OBJECT),
 				 errmsg("duplicate connection name")));
+	}
 
 	hentry->rconn = rconn;
 	strncpy(hentry->name, name, NAMEDATALEN - 1);