From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 8 Oct 2021 19:07:41 +0000 (+0200)
Subject: parse-options.h: make the "flags" in "struct option" an enum
X-Git-Tag: v2.34.0-rc0~31^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7bf7f0ba05b999e890f5738e08a7f5f70b71c633;p=thirdparty%2Fgit.git

parse-options.h: make the "flags" in "struct option" an enum

Change the "flags" members of "struct option" to refer to their
corresponding "enum" defined earlier in the file.

The benefit of changing this to an enum isn't as great as with some
"enum parse_opt_type" as we'll always check this as a bitfield, so we
can't rely on the compiler checking "case" arms for us. But let's do
it for consistency with the rest of the file.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/parse-options.h b/parse-options.h
index a1c7c86ad3..74b66ba6e9 100644
--- a/parse-options.h
+++ b/parse-options.h
@@ -134,7 +134,7 @@ struct option {
 	const char *argh;
 	const char *help;
 
-	int flags;
+	enum parse_opt_option_flags flags;
 	parse_opt_cb *callback;
 	intptr_t defval;
 	parse_opt_ll_cb *ll_callback;