From: Christian Brauner <brauner@kernel.org>
Date: Mon, 25 Nov 2024 14:10:05 +0000 (+0100)
Subject: target_core_configfs: avoid pointless cred reference count bump
X-Git-Tag: v6.14-rc1~214^2~1^2~20
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7c0c3b346adafb515a5ff085c68c92695c4fdb04;p=thirdparty%2Fkernel%2Flinux.git

target_core_configfs: avoid pointless cred reference count bump

The creds are allocated via prepare_kernel_cred() which has already
taken a reference.

Link: https://lore.kernel.org/r/20241125-work-cred-v2-9-68b9d38bb5b2@kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index ec7a559871939..c40217f44b1bc 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -3756,9 +3756,9 @@ static int __init target_core_init_configfs(void)
 		ret = -ENOMEM;
 		goto out;
 	}
-	old_cred = override_creds(get_new_cred(kern_cred));
+	old_cred = override_creds(kern_cred);
 	target_init_dbroot();
-	put_cred(revert_creds(old_cred));
+	revert_creds(old_cred);
 	put_cred(kern_cred);
 
 	return 0;