From: Felix Fietkau <nbd@nbd.name>
Date: Mon, 15 Sep 2025 07:59:00 +0000 (+0200)
Subject: wifi: mt76: mt7996: fix memory leak on mt7996_mcu_sta_key_tlv error
X-Git-Tag: v6.18-rc1~132^2~56^2~27^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7c0f63fe37a5da2c13fc35c89053b31be8ead895;p=thirdparty%2Fkernel%2Flinux.git

wifi: mt76: mt7996: fix memory leak on mt7996_mcu_sta_key_tlv error

Free the allocated skb on error

Link: https://patch.msgid.link/20250915075910.47558-5-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---

diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
index 5c16e4b780adb..5707e6b59aeaf 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
@@ -2614,8 +2614,10 @@ int mt7996_mcu_add_key(struct mt76_dev *dev, struct ieee80211_vif *vif,
 		return PTR_ERR(skb);
 
 	ret = mt7996_mcu_sta_key_tlv(wcid, skb, key, cmd);
-	if (ret)
+	if (ret) {
+		dev_kfree_skb(skb);
 		return ret;
+	}
 
 	return mt76_mcu_skb_send_msg(dev, skb, mcu_cmd, true);
 }