From: René Scharfe <l.s.r@web.de>
Date: Sun, 20 Nov 2022 11:00:52 +0000 (+0100)
Subject: list-objects-filter: plug combine_filter_data leak
X-Git-Tag: v2.39.0-rc1~15^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7c2dc122f91970ea89a8af0053fbc655a9d58517;p=thirdparty%2Fgit.git

list-objects-filter: plug combine_filter_data leak

filter_combine__init() allocates a struct combine_filter_data object and
assigns it to the filter_data member of struct filter_options.  Release
it in the complementing filter_combine__free().

Reported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/list-objects-filter.c b/list-objects-filter.c
index 1c1ee3d1bb..b9543545ca 100644
--- a/list-objects-filter.c
+++ b/list-objects-filter.c
@@ -709,6 +709,7 @@ static void filter_combine__free(void *filter_data)
 			BUG("expected oidset to be cleared already");
 	}
 	free(d->sub);
+	free(d);
 }
 
 static void add_all(struct oidset *dest, struct oidset *src) {