From: Willy Tarreau <w@1wt.eu>
Date: Sat, 16 Oct 2021 12:54:19 +0000 (+0200)
Subject: BUG/MINOR: listener: add an error check for unallocatable trash
X-Git-Tag: v2.5-dev10~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7c4c830d04d53ed31e10a4f849b8ff96034e7690;p=thirdparty%2Fhaproxy.git

BUG/MINOR: listener: add an error check for unallocatable trash

Coverity noticed in issue #1416 that a missing allocation error was
introduced in tcp_bind_listener() with the rework of error messages by
commit ed1748553 ("MINOR: proto_tcp: use chunk_appendf() to ouput socket
setup errors"). In practice nobody will ever face it but better address
it anyway.

No backport is needed.
---

diff --git a/src/proto_tcp.c b/src/proto_tcp.c
index 18e9b80e49..a8b15b21ad 100644
--- a/src/proto_tcp.c
+++ b/src/proto_tcp.c
@@ -589,6 +589,12 @@ int tcp_bind_listener(struct listener *listener, char *errmsg, int errlen)
 
 	err = ERR_NONE;
 
+	if (!msg) {
+		if (errlen)
+			snprintf(errmsg, errlen, "out of memory");
+		return ERR_ALERT | ERR_FATAL;
+	}
+
 	/* ensure we never return garbage */
 	if (errlen)
 		*errmsg = 0;