From: Ignat Korchagin Date: Mon, 14 Oct 2024 15:38:01 +0000 (+0100) Subject: Bluetooth: L2CAP: do not leave dangling sk pointer on error in l2cap_sock_create() X-Git-Tag: v6.13-rc1~135^2~306^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7c4f78cdb8e7501e9f92d291a7d956591bf73be9;p=thirdparty%2Fkernel%2Flinux.git Bluetooth: L2CAP: do not leave dangling sk pointer on error in l2cap_sock_create() bt_sock_alloc() allocates the sk object and attaches it to the provided sock object. On error l2cap_sock_alloc() frees the sk object, but the dangling pointer is still attached to the sock object, which may create use-after-free in other code. Signed-off-by: Ignat Korchagin Reviewed-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Link: https://patch.msgid.link/20241014153808.51894-3-ignat@cloudflare.com Signed-off-by: Jakub Kicinski --- diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c index ba437c6f6ee59..18e89e764f3b4 100644 --- a/net/bluetooth/l2cap_sock.c +++ b/net/bluetooth/l2cap_sock.c @@ -1886,6 +1886,7 @@ static struct sock *l2cap_sock_alloc(struct net *net, struct socket *sock, chan = l2cap_chan_create(); if (!chan) { sk_free(sk); + sock->sk = NULL; return NULL; }