From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 1 Aug 2024 18:51:12 +0000 (-0700)
Subject: t0018: remove leftover debugging cruft
X-Git-Tag: v2.46.1~28^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7c7516b8db8b2e6d03379c0e81292cc11e7836bf;p=thirdparty%2Fgit.git

t0018: remove leftover debugging cruft

The actual file is copied out to /tmp, presumably so that the tester
can inspect it after the test is done, which may have been a useful
debugging aid.

But in the final shape of the test suite, such a code should not
exist.  We cannot even assume that we are allowed to write into /tmp
(our TMPDIR may not even be pointing at it) or read from it for that
matter.

Noticed-by: Randall S. Becker <rsbecker@nexbridge.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/t0018-advice.sh b/t/t0018-advice.sh
index b02448ea16..040a08be07 100755
--- a/t/t0018-advice.sh
+++ b/t/t0018-advice.sh
@@ -93,7 +93,6 @@ EOF
 		>README &&
 		GIT_ADVICE=true git status
 	) >actual &&
-	cat actual > /tmp/actual &&
 	test_cmp expect actual
 '