From: Colin Ian King <colin.king@canonical.com>
Date: Thu, 7 Sep 2017 13:51:33 +0000 (+0100)
Subject: scsi: libcxgbi: remove redundant check and close on csk
X-Git-Tag: v4.15-rc1~125^2~191
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7c82532dcce8b39991ef5f486c2b54d7bb3e171b;p=thirdparty%2Flinux.git

scsi: libcxgbi: remove redundant check and close on csk

csk is always null on the error return path and so the non-null check
and call to cxgbi_sock_closed on csk is redundant and can be removed.

Detected by: CoverityScan CID#114329 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index 512c8f1ea5b06..da36c2de069e7 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -688,8 +688,6 @@ rel_neigh:
 
 rel_rt:
 	ip_rt_put(rt);
-	if (csk)
-		cxgbi_sock_closed(csk);
 err_out:
 	return ERR_PTR(err);
 }