From: Mateusz Kusiak <mateusz.kusiak@intel.com>
Date: Tue, 20 Feb 2024 10:56:11 +0000 (+0100)
Subject: super1: check fd before passing to get_dev_size() in add_to_super1()
X-Git-Tag: mdadm-4.4~237
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7ccf947eb595c1bb729c32ba18ce171dada76a68;p=thirdparty%2Fmdadm.git

super1: check fd before passing to get_dev_size() in add_to_super1()

Check if file descriptor is valid before passing it to get_dev_size() in
add_to_super().

Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com>
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
---

diff --git a/super1.c b/super1.c
index 871d19f0..5439b7bb 100644
--- a/super1.c
+++ b/super1.c
@@ -1752,7 +1752,10 @@ static int add_to_super1(struct supertype *st, mdu_disk_info_t *dk,
 	di->devname = devname;
 	di->disk = *dk;
 	di->data_offset = data_offset;
-	get_dev_size(fd, NULL, &di->dev_size);
+
+	if (is_fd_valid(fd))
+		get_dev_size(fd, NULL, &di->dev_size);
+
 	di->next = NULL;
 	*dip = di;