From: MoYuanhao Date: Wed, 6 Nov 2024 07:10:35 +0000 (+0800) Subject: mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone() X-Git-Tag: v6.13-rc1~135^2~100 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7d28f4fc868ccc26124d368e8d2ead9d21c23542;p=thirdparty%2Fkernel%2Flinux.git mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone() The variable has already been assigned in the subflow_create_ctx(), So we don't need to reassign this variable in the subflow_ulp_clone(). Signed-off-by: MoYuanhao Reviewed-by: Matthieu Baerts (NGI0) Link: https://patch.msgid.link/20241106071035.2591-1-moyuanhao3676@163.com Signed-off-by: Jakub Kicinski --- diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 07352b15f1458..fd021cf8286ef 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -2049,7 +2049,6 @@ static void subflow_ulp_clone(const struct request_sock *req, new_ctx->tcp_state_change = old_ctx->tcp_state_change; new_ctx->tcp_error_report = old_ctx->tcp_error_report; new_ctx->rel_write_seq = 1; - new_ctx->tcp_sock = newsk; if (subflow_req->mp_capable) { /* see comments in subflow_syn_recv_sock(), MPTCP connection