From: Frédéric Buclin <LpSolit@gmail.com>
Date: Sat, 5 Mar 2016 11:51:08 +0000 (+0100)
Subject: Some more cleanup in xt/
X-Git-Tag: release-5.1.1~61
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7d2b61efa6db4f515c1d9640e1beda89138f9e00;p=thirdparty%2Fbugzilla.git

Some more cleanup in xt/
---

diff --git a/xt/lib/QA/REST.pm b/xt/lib/QA/REST.pm
index 1ceeb955ba..23d4f4433d 100644
--- a/xt/lib/QA/REST.pm
+++ b/xt/lib/QA/REST.pm
@@ -63,3 +63,5 @@ sub call {
         die 'error ' . $res->{code} . ': ' . $res->{message} . "\n";
     }
 }
+
+1;
diff --git a/xt/lib/QA/RPC/JSONRPC.pm b/xt/lib/QA/RPC/JSONRPC.pm
index ce31228699..10e0d3a69c 100644
--- a/xt/lib/QA/RPC/JSONRPC.pm
+++ b/xt/lib/QA/RPC/JSONRPC.pm
@@ -126,7 +126,10 @@ sub _get {
 1;
 
 package QA::RPC::JSONRPC::ReturnObject;
+
+use 5.14.0;
 use strict;
+use warnings;
 
 BEGIN {
     if (eval { require JSON::RPC::Client }) {
@@ -149,8 +152,12 @@ sub fault { $_[0]->is_error }
 1;
 
 package QA::RPC::UserAgent;
+
+use 5.14.0;
 use strict;
-use base qw(LWP::UserAgent);
+use warnings;
+
+use parent  qw(LWP::UserAgent);
 
 ########################################
 # Consistency with XMLRPC::Lite's ->ua #
@@ -172,3 +179,5 @@ sub http_response {
     if (@_) { $self->{'_http_response'} = shift; return $self }
     return $self->{'_http_response'};
 }
+
+1;
diff --git a/xt/lib/QA/RPC/XMLRPC.pm b/xt/lib/QA/RPC/XMLRPC.pm
index ced9f97eeb..7e4bcac240 100644
--- a/xt/lib/QA/RPC/XMLRPC.pm
+++ b/xt/lib/QA/RPC/XMLRPC.pm
@@ -16,11 +16,9 @@ use warnings;
 use FindBin qw($RealBin);
 use lib "$RealBin/../../../lib", "$RealBin/../../../../local/lib/perl5";
 
-use base qw(QA::RPC XMLRPC::Lite);
+use parent qw(QA::RPC XMLRPC::Lite);
 
 use constant TYPE => 'XML-RPC';
 use constant DATETIME_REGEX => qr/^\d{8}T\d\d:\d\d:\d\d$/;
 
 1;
-
-__END__
diff --git a/xt/lib/QA/Tests.pm b/xt/lib/QA/Tests.pm
index d0a32cfc6c..a76f0601bb 100644
--- a/xt/lib/QA/Tests.pm
+++ b/xt/lib/QA/Tests.pm
@@ -16,7 +16,8 @@ use warnings;
 use FindBin qw($RealBin);
 use lib "$RealBin/../../lib", "$RealBin/../../../local/lib/perl5";
 
-use base qw(Exporter);
+use parent qw(Exporter);
+
 our @EXPORT_OK = qw(
     PRIVATE_BUG_USER
     STANDARD_BUG_TESTS