From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Fri, 24 Aug 2018 05:10:58 +0000 (-0400)
Subject: closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl... 
X-Git-Tag: v3.6.7rc1~89
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7d470f3f24d0c091cf1da4f13695c6bb3200a713;p=thirdparty%2FPython%2Fcpython.git

closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl() (GH-8872)


Reported by Svace static analyzer.
(cherry picked from commit 2b824b2538c4a5f9f520c5de8a1eae5a0c181a94)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
---

diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
index 5ee08e67e7fb..d7b0bbd331da 100644
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -2343,6 +2343,11 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start)
                 }
             }
             result = PyFloat_FromDouble(f_result);
+            if (result == NULL) {
+                Py_DECREF(item);
+                Py_DECREF(iter);
+                return NULL;
+            }
             temp = PyNumber_Add(result, item);
             Py_DECREF(result);
             Py_DECREF(item);