From: james <james@e7ae566f-a301-0410-adde-c780ea21d3b5>
Date: Wed, 1 Nov 2006 21:21:01 +0000 (+0000)
Subject: SO_REUSEADDR should not be set on Windows TCP sockets because
X-Git-Tag: v2.1_rc2~20
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7d770f1e8d2e21fbd7886ee1744007b86c5a3ece;p=thirdparty%2Fopenvpn.git

SO_REUSEADDR should not be set on Windows TCP sockets because
it will cause bind to succeed on port conflicts.


git-svn-id: http://svn.openvpn.net/projects/openvpn/branches/BETA21/openvpn@1428 e7ae566f-a301-0410-adde-c780ea21d3b5
---

diff --git a/socket.c b/socket.c
index 96e05628e..a37229536 100644
--- a/socket.c
+++ b/socket.c
@@ -482,6 +482,7 @@ create_socket_tcp (void)
   if ((sd = socket (PF_INET, SOCK_STREAM, IPPROTO_TCP)) < 0)
     msg (M_SOCKERR, "Cannot create TCP socket");
 
+#ifndef WIN32 /* using SO_REUSEADDR on Windows will cause bind to succeed on port conflicts! */
   /* set SO_REUSEADDR on socket */
   {
     int on = 1;
@@ -489,6 +490,7 @@ create_socket_tcp (void)
 		    (void *) &on, sizeof (on)) < 0)
       msg (M_SOCKERR, "TCP: Cannot setsockopt SO_REUSEADDR on TCP socket");
   }
+#endif
 
 #if 0
   /* set socket linger options */