From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: Wed, 27 May 2020 23:02:07 +0000 (+0200)
Subject: media: ccs: The functions to get compose or crop rectangle never return NULL
X-Git-Tag: v5.11-rc1~203^2~109
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7d8d59f260bad0b3b11dc94e88b4195a2d1798af;p=thirdparty%2Fkernel%2Flinux.git

media: ccs: The functions to get compose or crop rectangle never return NULL

The NULL check is not needed as the functions do not return NULL. Remove
the check (and BUG).

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
index dec248fe7cc12..25b4c84524fff 100644
--- a/drivers/media/i2c/ccs/ccs-core.c
+++ b/drivers/media/i2c/ccs/ccs-core.c
@@ -1766,16 +1766,12 @@ static void ccs_get_crop_compose(struct v4l2_subdev *subdev,
 			*comps = &ssd->compose;
 	} else {
 		if (crops) {
-			for (i = 0; i < subdev->entity.num_pads; i++) {
+			for (i = 0; i < subdev->entity.num_pads; i++)
 				crops[i] = v4l2_subdev_get_try_crop(subdev, cfg, i);
-				BUG_ON(!crops[i]);
-			}
 		}
-		if (comps) {
+		if (comps)
 			*comps = v4l2_subdev_get_try_compose(subdev, cfg,
 							     CCS_PAD_SINK);
-			BUG_ON(!*comps);
-		}
 	}
 }