From: Jakub Kicinski Date: Thu, 16 Oct 2025 22:58:24 +0000 (-0700) Subject: Merge branch 'net-stmmac-more-cleanups' X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7dbef65e54820e3041699c8bae9abf5ff09a6459;p=thirdparty%2Fkernel%2Flinux.git Merge branch 'net-stmmac-more-cleanups' Russell King says: ==================== net: stmmac: more cleanups The subject for the cover message is wearing thin as I've used it a number of times, but the scope for cleaning up the driver continues, and continue it will do, because this is just a small fraction of the queue. 1. make a better job of one of my previous commits, moving the holding of the lock into stmmac_mdio.c 2. move the mac_finish() method to be in-order with the layout of struct phylink_mac_ops - this order was chosen because it reflects the order that the methods are called, thus making the flow more obvious when reading code. 3. continuing on the "removal of stuff that doesn't need to happen", patch 3 removes the phylink_speed_(up|down) out of the path that is used for MTU changes - we really don't need to fiddle with the PHY advertisement when changing the MTU! 4. clean up tc_init()'s initialisation of flow_entries_max - this is the sole place that this is written, and we might as well make the code more easy to follow. 5. stmmac_phy_setup() really confuses me when I read the code, it's not really about PHY setup, but about phylink setup. So, name its name reflect its functionality. ==================== Link: https://patch.msgid.link/aO_HIwT_YvxkDS8D@shell.armlinux.org.uk Signed-off-by: Jakub Kicinski --- 7dbef65e54820e3041699c8bae9abf5ff09a6459