From: Stefan Schmidt <stefan@osg.samsung.com>
Date: Thu, 12 Apr 2018 12:28:49 +0000 (+0200)
Subject: net: ieee802154: mcr20a: do not leak resources on error path
X-Git-Tag: v4.17-rc5~9^2~32^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7e0ffee1b2e7d26cc2147be0d9d5186823e923f3;p=thirdparty%2Fkernel%2Flinux.git

net: ieee802154: mcr20a: do not leak resources on error path

We already allocated the device and platform  data at this
point. Instead of simply return from the probe function we
need to cleanup the resources first.

Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
Acked-by: Xue Liu <liuxuenetmail@gmail.com>
---

diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index 944470d69ba9a..de0d7f28a181c 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -1309,8 +1309,10 @@ mcr20a_probe(struct spi_device *spi)
 	/* init buf */
 	lp->buf = devm_kzalloc(&spi->dev, SPI_COMMAND_BUFFER, GFP_KERNEL);
 
-	if (!lp->buf)
-		return -ENOMEM;
+	if (!lp->buf) {
+		ret = -ENOMEM;
+		goto free_dev;
+	}
 
 	mcr20a_setup_tx_spi_messages(lp);
 	mcr20a_setup_rx_spi_messages(lp);