From: Bill Schaller <billschaller@fb.com>
Date: Wed, 8 Mar 2017 19:03:30 +0000 (-0500)
Subject: [Easy] Don't enumerate momentProperties with 'in'
X-Git-Tag: 2.18.0~16^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7e1f710ac07c98776ef7d03c43eb5395aa01a4c0;p=thirdparty%2Fmoment.git

[Easy] Don't enumerate momentProperties with 'in'

Because of the way many polyfill libraries modify Array.prototype (without Object.defineProperty), enumerating momentProperties with for...in is unsafe.

This is a zero-cost change that makes this enumeration safe.
---

diff --git a/src/lib/moment/constructor.js b/src/lib/moment/constructor.js
index 83f83effe..bc53f814f 100644
--- a/src/lib/moment/constructor.js
+++ b/src/lib/moment/constructor.js
@@ -42,7 +42,7 @@ export function copyConfig(to, from) {
     }
 
     if (momentProperties.length > 0) {
-        for (i in momentProperties) {
+        for (i = 0; i < momentProperties.length; i++) {
             prop = momentProperties[i];
             val = from[prop];
             if (!isUndefined(val)) {