From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Wed, 7 Mar 2018 09:24:30 +0000 (+0200)
Subject: notify: Fix crash if NO_NOTIFY transaction is rolled back during commit
X-Git-Tag: 2.2.35~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7e3bfd19ecc6063224e92156cd9f4db380dc6654;p=thirdparty%2Fdovecot%2Fcore.git

notify: Fix crash if NO_NOTIFY transaction is rolled back during commit

Fixes: Panic: no notify_mail_txn found
---

diff --git a/src/plugins/notify/notify-storage.c b/src/plugins/notify/notify-storage.c
index 5ab08718f5..2b23ea3a75 100644
--- a/src/plugins/notify/notify-storage.c
+++ b/src/plugins/notify/notify-storage.c
@@ -145,7 +145,8 @@ notify_transaction_commit(struct mailbox_transaction_context *t,
 	bool no_notify = (t->flags & MAILBOX_TRANSACTION_FLAG_NO_NOTIFY) != 0;
 
 	if ((lbox->super.transaction_commit(t, changes_r)) < 0) {
-		notify_contexts_mail_transaction_rollback(t);
+		if (!no_notify)
+			notify_contexts_mail_transaction_rollback(t);
 		return -1;
 	}