From: Adam Kwolek <adam.kwolek@intel.com>
Date: Tue, 14 Jun 2011 02:48:53 +0000 (+1000)
Subject: imsm: Fix: klocwork: targets variable can be used uninitialized
X-Git-Tag: mdadm-3.2.2~17
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7e45b5504c66d29b77c16f59dc4f8f0de72145ba;p=thirdparty%2Fmdadm.git

imsm: Fix: klocwork: targets variable can be used uninitialized

When target_offsets allocation fails execution goes to abort label,
where elements from targets table are closed.

Initialize targets table after allocation.

Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/super-intel.c b/super-intel.c
index 7190f515..6c74e503 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -7716,13 +7716,15 @@ int save_backup_imsm(struct supertype *st,
 	if (!targets)
 		goto abort;
 
+	for (i = 0; i < new_disks; i++)
+		targets[i] = -1;
+
 	target_offsets = malloc(new_disks * sizeof(unsigned long long));
 	if (!target_offsets)
 		goto abort;
 
 	start = info->reshape_progress * 512;
 	for (i = 0; i < new_disks; i++) {
-		targets[i] = -1;
 		target_offsets[i] = (unsigned long long)
 		  __le32_to_cpu(super->migr_rec->ckpt_area_pba) * 512;
 		/* move back copy area adderss, it will be moved forward