From: Serge Hallyn <serge@hallyn.com>
Date: Wed, 26 Mar 2025 13:23:52 +0000 (-0500)
Subject: Quick fix: define E_PAM_ERR in lib/pam_pass.c
X-Git-Tag: 4.18.0-rc1~111
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7e605222df006458a2edfbbe3875db858eff115e;p=thirdparty%2Fshadow.git

Quick fix: define E_PAM_ERR in lib/pam_pass.c

The exit code situation is a hot mess. Do a
  git grep "define.*E_SUCCESS"
Each src/*.c is defining its own set of error codes, and
they are frequently conflicting, e.g. more than one use
10.

We should probably have a common set defined in lib/exitcodes.h.
I'm thinking for a first cut, we just move all the definitions
from src/*.c to lib/exitcodes.h, and let the conflicts stand.
If we later want to change some defines to make them unambiguous
across the project, we can do that separately.

Signed-off-by: Serge Hallyn <serge@hallyn.com>
---

diff --git a/lib/pam_pass.c b/lib/pam_pass.c
index 0e3ec4c03..335365689 100644
--- a/lib/pam_pass.c
+++ b/lib/pam_pass.c
@@ -10,6 +10,9 @@
 
 #ifdef USE_PAM
 
+/* Copied from src/passwd.c */
+#define E_PAM_ERR	10	/* PAM returned an error */
+
 #ident "$Id$"