From: Alejandro Colomar <alx@kernel.org>
Date: Tue, 9 Jan 2024 19:21:39 +0000 (+0100)
Subject: lib/shadow.c: my_sgetspent(): Remove dead code
X-Git-Tag: 4.17.0-rc1~157
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7e754cc44747a99755e063e7cdaeeffef8df1185;p=thirdparty%2Fshadow.git

lib/shadow.c: my_sgetspent(): Remove dead code

spwd.sp_flag is an unsigned long, which can never be negative.

Reviewed-by: "Serge E. Hallyn" <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/shadow.c b/lib/shadow.c
index 8c1fc8a5e..a593e54a4 100644
--- a/lib/shadow.c
+++ b/lib/shadow.c
@@ -195,8 +195,6 @@ static struct spwd *my_sgetspent (const char *string)
 		spwd.sp_flag = SHADOW_SP_FLAG_UNSET;
 	else if (str2ul(&spwd.sp_flag, fields[8]) == -1)
 		return 0;
-	else if (spwd.sp_flag < 0)
-		return 0;
 
 	return (&spwd);
 }