From: Amos Jeffries <squid3@treenet.co.nz>
Date: Tue, 14 Jan 2014 21:29:20 +0000 (+1300)
Subject: Fix memory leak in peer cache Digest exchange
X-Git-Tag: SQUID_3_5_0_1~415
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7e928efc7afbb23c80ce624afda0144de74c2abc;p=thirdparty%2Fsquid.git

Fix memory leak in peer cache Digest exchange

 Detected by Coverity Scan. Issue 1094115.
---

diff --git a/src/peer_digest.cc b/src/peer_digest.cc
index 60559dc4ce..7bd4988862 100644
--- a/src/peer_digest.cc
+++ b/src/peer_digest.cc
@@ -300,7 +300,7 @@ peerDigestRequest(PeerDigest * pd)
 {
     CachePeer *p = pd->peer;
     StoreEntry *e, *old_e;
-    char *url;
+    char *url = NULL;
     const cache_key *key;
     HttpRequest *req;
     DigestFetchState *fetch = NULL;
@@ -398,6 +398,8 @@ peerDigestRequest(PeerDigest * pd)
 
     storeClientCopy(fetch->sc, e, tempBuffer,
                     peerDigestHandleReply, fetch);
+
+    safe_free(url);
 }
 
 /* Handle the data copying .. */