From: drh <drh@noemail.net>
Date: Sat, 23 Feb 2019 00:21:00 +0000 (+0000)
Subject: Check-in [fa792714ae62fa98] is incorrect.  Add a test case to refute it and
X-Git-Tag: version-3.28.0~162
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7f414c0c0c503ab968f7072fcd28a876eacff427;p=thirdparty%2Fsqlite.git

Check-in [fa792714ae62fa98] is incorrect.  Add a test case to refute it and
also a fix to make it right.
Then add an alternative fix to ticket [df46dfb631f75694] in which
all ephemeral tables used as the RHS of an IN operator be index btrees
and never table btrees so that they can always be reused.

FossilOrigin-Name: d3915230e3ee5878fe2e65a0afb7e91ee124aaf46b4e28c6e00053d6df13d445
---

7f414c0c0c503ab968f7072fcd28a876eacff427
diff --cc manifest
index 1c480ce80d,d7d81d4706..5bceb98aca
--- a/manifest
+++ b/manifest
@@@ -1,5 -1,5 +1,5 @@@
- C Internally,\sremove\sall\sreferences\sto\sa\sWindow\sobject\sthat\sbelongs\sto\san\sexpression\sin\san\sORDER\sBY\sclause\sif\sthat\sexpression\sis\sconverted\sto\san\salias\sof\sa\sresult-set\sexpression.\sFix\sfor\s[4feb3159c6].
- D 2019-02-22T19:24:16.635
 -C Remove\sa\stestcase()\smacro\swhich\sis\snow\sunreachable\sdue\sto\sthe\scontraction\sof\nthe\suse\sof\sIN_INDEX_ROWID.
 -D 2019-02-23T00:08:09.169
++C Check-in\s[fa792714ae62fa98]\sis\sincorrect.\s\sAdd\sa\stest\scase\sto\srefute\sit\sand\nalso\sa\sfix\sto\smake\sit\sright.\s\nThen\sadd\san\salternative\sfix\sto\sticket\s[df46dfb631f75694]\sin\swhich\nall\sephemeral\stables\sused\sas\sthe\sRHS\sof\san\sIN\soperator\sbe\sindex\sbtrees\nand\snever\stable\sbtrees\sso\sthat\sthey\scan\salways\sbe\sreused.
++D 2019-02-23T00:21:00.186
  F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
  F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
  F Makefile.in 178d8eb6840771149cee40b322d1b3be30d330198c522c903c1b66fb5a1bfca4
@@@ -1805,7 -1805,7 +1805,8 @@@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a9
  F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
  F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
  F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
- P 73056b314bd63288c662752e9bd469b70264c38031c1c857460e64fdb1ed4e2e
- R 0862848065a4a98f23b3c741ebf45b9f
- U dan
- Z 231e5f595c30e40261d6e69369fc6dc0
 -P c2d50df8fd1a1fdae6226a3e77296ded09b53a74540caedd4868e686a93cbc10
++P 579b66eaa0816561c6e47ea116b46f229188f0fc84c1173bfe0d21df2dff9a9a 90c5a17cd526b256753f876e575f3e731d5e8b9dd6e196cf8d8f7306e099b91c
+ R c922ba3f62286cb9bc5a2acd31d21a66
++T +closed 90c5a17cd526b256753f876e575f3e731d5e8b9dd6e196cf8d8f7306e099b91c
+ U drh
 -Z 4c57ce6adbcc41ffca57692643360ae6
++Z 6d379fa0271550d77de94db4756b85a3
diff --cc manifest.uuid
index 8b38972d81,2c4694a5fd..7f507cdb90
--- a/manifest.uuid
+++ b/manifest.uuid
@@@ -1,1 -1,1 +1,1 @@@
- 579b66eaa0816561c6e47ea116b46f229188f0fc84c1173bfe0d21df2dff9a9a
 -90c5a17cd526b256753f876e575f3e731d5e8b9dd6e196cf8d8f7306e099b91c
++d3915230e3ee5878fe2e65a0afb7e91ee124aaf46b4e28c6e00053d6df13d445