From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 19 Jul 2022 19:10:33 +0000 (+0200)
Subject: qemu: validate: Remove impossible validation checks
X-Git-Tag: v8.7.0-rc1~111
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7f70cedc947b70f5531529ee662f8261eb5ff27e;p=thirdparty%2Flibvirt.git

qemu: validate: Remove impossible validation checks

All supported qemu versions now work with blockdev.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index b13c27bcf0..5c68a65fdc 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -707,13 +707,6 @@ qemuValidateDomainDefNvram(const virDomainDef *def,
     if (!src)
         return 0;
 
-    if (def->os.loader->newStyleNVRAM &&
-        !virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                       _("modern nvram specification is not supported by this qemu"));
-        return -1;
-    }
-
     switch (src->type) {
     case VIR_STORAGE_TYPE_FILE:
     case VIR_STORAGE_TYPE_BLOCK:
@@ -3315,13 +3308,6 @@ qemuValidateDomainDeviceDefDiskTransient(const virDomainDiskDef *disk,
         return -1;
     }
 
-    if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("transient disk not supported by this QEMU binary (%s)"),
-                       disk->dst);
-        return -1;
-    }
-
     if (disk->transientShareBacking == VIR_TRISTATE_BOOL_YES) {
         if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SET_ACTION) &&
             !qemuProcessRebootAllowed(def)) {