From: Haibo Chen Date: Wed, 12 Nov 2025 11:05:13 +0000 (+0800) Subject: mtd: spi-nor: micron-st: add TODO for fixing mt35xu02gcba X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7f77c561e22783387af91cd16f3a4324a99c9a4f;p=thirdparty%2Flinux.git mtd: spi-nor: micron-st: add TODO for fixing mt35xu02gcba The MT35XU02GCBA flash device does not support chip erase, according to its datasheet. It supports die erase, which means the current driver implementation will likely need to be converted to use die erase. Furthermore, similar to the MT35XU01GBBA, the SPI_NOR_IO_MODE_EN_VOLATILE flag probably needs to be enabled. Currently no active contributor has access to this hardware so there is no way of testing the fixes. Add a TODO item on the flash entry so someone with the flash can test that the support is indeed broken and send the fixes. Link: https://datasheet.octopart.com/MT35XU02GCBA1G12-0AAT-Micron-datasheet-138896808.pdf Reviewed-by: Tudor Ambarus Signed-off-by: Haibo Chen [pratyush@kernel.org: refactor the comment and commit message to make the purpose of the comment clearer] Signed-off-by: Pratyush Yadav --- diff --git a/drivers/mtd/spi-nor/micron-st.c b/drivers/mtd/spi-nor/micron-st.c index c89c06b1fc61a..88033384a71e5 100644 --- a/drivers/mtd/spi-nor/micron-st.c +++ b/drivers/mtd/spi-nor/micron-st.c @@ -204,6 +204,16 @@ static const struct flash_info micron_nor_parts[] = { .fixup_flags = SPI_NOR_IO_MODE_EN_VOLATILE, .fixups = &mt35xu01gbba_fixups, }, { + /* + * The MT35XU02GCBA flash device does not support chip erase, + * according to its datasheet. It supports die erase, which + * means the current driver implementation will likely need to + * be converted to use die erase. Furthermore, similar to the + * MT35XU01GBBA, the SPI_NOR_IO_MODE_EN_VOLATILE flag probably + * needs to be enabled. + * + * TODO: Fix these and test on real hardware. + */ .id = SNOR_ID(0x2c, 0x5b, 0x1c), .name = "mt35xu02g", .sector_size = SZ_128K,