From: Jani Nikula <ext-jani.1.nikula@nokia.com>
Date: Tue, 1 Jun 2010 14:33:54 +0000 (+0300)
Subject: OMAP: DSS2: OMAPFB: Remove redundant color register range check
X-Git-Tag: v2.6.36-rc1~487^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7f8b183059edc6c74654301431d520a91539e45f;p=thirdparty%2Fkernel%2Flinux.git

OMAP: DSS2: OMAPFB: Remove redundant color register range check

Unsigned regno can never be less than zero. Found by Coverity.

Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
---

diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 8303776647fcc..4abb1d17231b2 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -1208,11 +1208,6 @@ static int _setcolreg(struct fb_info *fbi, u_int regno, u_int red, u_int green,
 		if (r != 0)
 			break;
 
-		if (regno < 0) {
-			r = -EINVAL;
-			break;
-		}
-
 		if (regno < 16) {
 			u16 pal;
 			pal = ((red >> (16 - var->red.length)) <<