From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Mon, 1 Dec 2008 17:11:18 +0000 (+0000)
Subject: Modify the new to_timestamp implementation so that end-of-format-string
X-Git-Tag: REL8_4_BETA1~598
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7fb27531e8f51448f061a007534db67e0467a23e;p=thirdparty%2Fpostgresql.git

Modify the new to_timestamp implementation so that end-of-format-string
is treated like a non-digit separator. This fixes the inconsistency in
examples like:

to_timestamp('2008-01-2', 'YYYY-MM-DD') -- didn't work

and

to_timestamp('2008-1-02', 'YYYY-MM-DD') -- did work
---

diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
index 918701b8233..5496ca496fc 100644
--- a/src/backend/utils/adt/formatting.c
+++ b/src/backend/utils/adt/formatting.c
@@ -1,7 +1,7 @@
 /* -----------------------------------------------------------------------
  * formatting.c
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.150 2008/11/10 17:36:53 heikki Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.151 2008/12/01 17:11:18 heikki Exp $
  *
  *
  *	 Portions Copyright (c) 1999-2008, PostgreSQL Global Development Group
@@ -1678,8 +1678,9 @@ is_next_separator(FormatNode *n)
 	 */
 	n++;
 
+	/* end of format string is treated like a non-digit separator */
 	if (n->type == NODE_TYPE_END)
-		return FALSE;
+		return TRUE;
 
 	if (n->type == NODE_TYPE_ACTION)
 	{