From: Ileana Dumitrescu <ileanadumitrescu95@gmail.com>
Date: Thu, 14 Nov 2024 19:05:12 +0000 (+0200)
Subject: ltmain.in: Fix infinite loop for error messages
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7fd72bec1a83a7e0d60919abdfcb34bcc803b7d8;p=thirdparty%2Flibtool.git

ltmain.in: Fix infinite loop for error messages

If an invalid argument is passed to options '--mode' or '--reorder-cache'
after a valid command, error messages will print infinitely:

  $ libtool --help --mode=MODE
  libtool:   error: invalid argument 'MODE' for --mode
  libtool:   error: invalid argument 'MODE' for --mode
  libtool:   error: invalid argument 'MODE' for --mode
  ...

* build-aux/ltmain.in: Remove 'break' in case statement to fix infinite
  loop, and add shift for option '--reorder-cache' to allow more options
  to be processed.
---

diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index 9d891127f..4d7fc293d 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -474,7 +474,6 @@ libtool_parse_options ()
                           # Catch anything else as an error
                           *) func_error "invalid argument '$1' for $_G_opt"
                              exit_cmd=exit
-                             break
                              ;;
                         esac
                         shift
@@ -512,10 +511,10 @@ libtool_parse_options ()
                             *) func_error "invalid argument '$1' for $_G_opt"
                                func_error "absolute paths are required for $_G_opt"
                                exit_cmd=exit
-                               break
                                ;;
                           esac
                         fi
+                        shift
                         ;;
 
         --silent|--quiet)