From: hno <>
Date: Thu, 11 Apr 2002 04:12:31 +0000 (+0000)
Subject: Reported by Olaf Kirch:
X-Git-Tag: SQUID_3_0_PRE1~1104
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7fdc7d5d96c141f487667670fe98dee452157b95;p=thirdparty%2Fsquid.git

Reported by Olaf Kirch:
A possible buffer overflow in process_request
---

diff --git a/src/cachemgr.cc b/src/cachemgr.cc
index 1f4b131cac..864fadcfb8 100644
--- a/src/cachemgr.cc
+++ b/src/cachemgr.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: cachemgr.cc,v 1.91 2002/04/10 22:09:40 hno Exp $
+ * $Id: cachemgr.cc,v 1.92 2002/04/10 22:12:31 hno Exp $
  *
  * DEBUG: section 0     CGI Cache Manager
  * AUTHOR: Duane Wessels
@@ -532,8 +532,10 @@ process_request(cachemgr_request * req)
     }
     memset(&S, '\0', sizeof(struct sockaddr_in));
     S.sin_family = AF_INET;
-    if ((hp = gethostbyname(req->hostname)) != NULL)
+    if ((hp = gethostbyname(req->hostname)) != NULL) {
+	assert(hp->h_length <= sizeof(S.sin_addr.s_addr));
 	xmemcpy(&S.sin_addr.s_addr, hp->h_addr, hp->h_length);
+    }
     else if (safe_inet_addr(req->hostname, &S.sin_addr))
 	(void) 0;
     else {