From: Miaoqian Lin <linmq006@gmail.com>
Date: Tue, 18 Mar 2025 15:17:12 +0000 (+0800)
Subject: firmware: psci: Fix refcount leak in psci_dt_init
X-Git-Tag: v6.16-rc1~133^2~3^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=7ff37d29fd5c27617b9767e1b8946d115cf93a1e;p=thirdparty%2Flinux.git

firmware: psci: Fix refcount leak in psci_dt_init

Fix a reference counter leak in psci_dt_init() where of_node_put(np) was
missing after of_find_matching_node_and_match() when np is unavailable.

Fixes: d09a0011ec0d ("drivers: psci: Allow PSCI node to be disabled")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20250318151712.28763-1-linmq006@gmail.com
Signed-off-by: Will Deacon <will@kernel.org>
---

diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
index a1ebbe9b73b13..38ca190d4a22d 100644
--- a/drivers/firmware/psci/psci.c
+++ b/drivers/firmware/psci/psci.c
@@ -804,8 +804,10 @@ int __init psci_dt_init(void)
 
 	np = of_find_matching_node_and_match(NULL, psci_of_match, &matched_np);
 
-	if (!np || !of_device_is_available(np))
+	if (!np || !of_device_is_available(np)) {
+		of_node_put(np);
 		return -ENODEV;
+	}
 
 	init_fn = (psci_initcall_t)matched_np->data;
 	ret = init_fn(np);