From: Remi Tricot-Le Breton <rlebreton@haproxy.com>
Date: Wed, 16 Feb 2022 14:03:51 +0000 (+0100)
Subject: BUG/MINOR: ssl: Fix leak in "show ssl ocsp-response" CLI command
X-Git-Tag: v2.6-dev2~111
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8081b6769902899346f4c717007841190118d349;p=thirdparty%2Fhaproxy.git

BUG/MINOR: ssl: Fix leak in "show ssl ocsp-response" CLI command

When calling the "show ssl ocsp-response" CLI command some OpenSSL
objects need to be created in order to get some information related to
the OCSP response and some of them were not freed.

It should be backported to 2.5.
---

diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index d0acc80dd2..4d2fcc392f 100644
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -7511,9 +7511,12 @@ static int cli_io_handler_show_ocspresponse(struct appctx *appctx)
 
 		/* Decode the certificate ID (serialized into the key). */
 		d2i_OCSP_CERTID(&certid, &p, ocsp->key_length);
+		if (!certid)
+			goto end;
 
 		/* Dump the CERTID info */
 		ocsp_certid_print(bio, certid, 1);
+		OCSP_CERTID_free(certid);
 		write = BIO_read(bio, tmp->area, tmp->size-1);
 		/* strip trailing LFs */
 		while (write > 0 && tmp->area[write-1] == '\n')
@@ -7580,7 +7583,7 @@ int ssl_ocsp_response_print(struct buffer *ocsp_response, struct buffer *out)
 	resp = d2i_OCSP_RESPONSE(NULL, &p, ocsp_response->data);
 	if (!resp) {
 		chunk_appendf(out, "Unable to parse OCSP response");
-		return -1;
+		goto end;
 	}
 
 	if (OCSP_RESPONSE_print(bio, resp, 0) != 0) {
@@ -7623,9 +7626,12 @@ int ssl_ocsp_response_print(struct buffer *ocsp_response, struct buffer *out)
 		retval = (b_istput(out, ist_block) <= 0);
 	}
 
+end:
 	if (bio)
 		BIO_free(bio);
 
+	OCSP_RESPONSE_free(resp);
+
 	return retval;
 }