From: Willy Tarreau <w@1wt.eu>
Date: Fri, 15 Nov 2024 14:37:38 +0000 (+0100)
Subject: BUG/MINOR: debug: do not set task expiration to TICK_ETERNITY
X-Git-Tag: v3.1-dev13~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=808a7cc7775fd54762b94e5e6c0220d8a30453f7;p=thirdparty%2Fhaproxy.git

BUG/MINOR: debug: do not set task expiration to TICK_ETERNITY

Using "debug task", it's possible to change a task's expiration, but
we must be careful not to set it to TICK_ETERNITY. Let's use tick_add()
instead. The risk is basically nul since it's a debugging command, so
no backport is needed.
---

diff --git a/src/debug.c b/src/debug.c
index 78940bfc46..ee99135439 100644
--- a/src/debug.c
+++ b/src/debug.c
@@ -1420,7 +1420,7 @@ static int debug_parse_cli_task(char **args, char *payload, struct appctx *appct
 			else if (task_ok) {
 				/* unlink task and wake with timer flag */
 				__task_unlink_wq(t);
-				t->expire = now_ms;
+				t->expire = tick_add(now_ms, 0);
 				task_wakeup(t, TASK_WOKEN_TIMER);
 			}
 		} else if (strcmp(args[arg], "wake") == 0) {