From: Dan Carpenter Date: Wed, 27 Aug 2025 13:02:57 +0000 (+0300) Subject: media: ti: j721e-csi2rx: Fix NULL vs IS_ERR() bug in ti_csi2rx_request_max_ppc() X-Git-Tag: v6.18-rc1~133^2~165 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=80ae11c1a524015e4d9ef25c04fa3aacdcbe3a39;p=thirdparty%2Fkernel%2Fstable.git media: ti: j721e-csi2rx: Fix NULL vs IS_ERR() bug in ti_csi2rx_request_max_ppc() The media_entity_remote_source_pad_unique() function never returns NULL, it returns error pointers. Change this check from a NULL check to an IS_ERR() check. Fixes: 31f91c5224cd ("media: ti: j721e-csi2rx: Support multiple pixels per clock") Cc: stable@vger.kernel.org Signed-off-by: Dan Carpenter Reviewed-by: Jai Luthra Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c index 3992f8b754b75..b75aa363d1bf2 100644 --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c @@ -497,7 +497,7 @@ static void ti_csi2rx_request_max_ppc(struct ti_csi2rx_dev *csi) int ret; pad = media_entity_remote_source_pad_unique(&csi->vdev.entity); - if (!pad) + if (IS_ERR(pad)) return; ret = cdns_csi2rx_negotiate_ppc(csi->source, pad->index, &ppc);