From: Frediano Ziglio <frediano.ziglio@cloud.com>
Date: Mon, 21 Jul 2025 16:25:57 +0000 (+0100)
Subject: loader/arm64/xen_boot: Set correctly bootargs property for modules
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=80df5e13275cc5f090a971cf2b1240f32a99ca2e;p=thirdparty%2Fgrub.git

loader/arm64/xen_boot: Set correctly bootargs property for modules

The cmdline_size already account for NUL terminator, you can see
this in xen_boot_binary_load(). The same property is set correctly
for Xen command line.

Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
---

diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c
index 14afec143..ed22b49e0 100644
--- a/grub-core/loader/arm64/xen_boot.c
+++ b/grub-core/loader/arm64/xen_boot.c
@@ -174,7 +174,7 @@ prepare_xen_module_params (struct xen_boot_binary *module, void *xen_boot_fdt)
 		    module->cmdline, module->cmdline, module->cmdline_size);
 
       retval = grub_fdt_set_prop (xen_boot_fdt, module_node, "bootargs",
-				  module->cmdline, module->cmdline_size + 1);
+				  module->cmdline, module->cmdline_size);
       if (retval)
 	return grub_error (GRUB_ERR_IO, "failed to update FDT");
     }