From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 20 May 2025 12:56:03 +0000 (+0200)
Subject: virsh: Apply empty completer to arguments where completion doesn't make sense
X-Git-Tag: v11.4.0-rc1~28
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=811749a26691c9c5c4f0de130ed917ac70fe7bf9;p=thirdparty%2Flibvirt.git

virsh: Apply empty completer to arguments where completion doesn't make sense

Few outstanding arguments were not marked with 'virshCompleteEmpty'
completer despite the fact that we can't provide any reasonable
suggestion, e.g. for the new description of a domain or for the launch
secret.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 7e5e83126e..f9acedf3db 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -8696,6 +8696,7 @@ static const vshCmdOptDef opts_desc[] = {
     {.name = "new-desc",
      .type = VSH_OT_ARGV,
      .positional = true,
+     .completer = vshCompleteEmpty,
      .help = N_("message")
     },
     {.name = NULL}
@@ -9936,10 +9937,12 @@ static const vshCmdOptDef opts_domsetlaunchsecstate[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(0),
     {.name = "secrethdr",
      .type = VSH_OT_STRING,
+     .completer = vshCompleteEmpty,
      .help = N_("path to file containing the secret header"),
     },
     {.name = "secret",
      .type = VSH_OT_STRING,
+     .completer = vshCompleteEmpty,
      .help = N_("path to file containing the secret"),
     },
     {.name = "set-address",
@@ -10119,6 +10122,7 @@ static const vshCmdOptDef opts_qemu_monitor_command[] = {
      .type = VSH_OT_ARGV,
      .positional = true,
      .required = true,
+     .completer = vshCompleteEmpty,
      .help = N_("command")
     },
     {.name = NULL}
@@ -10503,6 +10507,7 @@ static const vshCmdOptDef opts_qemu_agent_command[] = {
      .type = VSH_OT_ARGV,
      .positional = true,
      .required = true,
+     .completer = vshCompleteEmpty,
      .help = N_("command")
     },
     {.name = NULL}
@@ -10590,6 +10595,7 @@ static const vshCmdOptDef opts_lxc_enter_namespace[] = {
      .type = VSH_OT_ARGV,
      .positional = true,
      .required = true,
+     .completer = vshCompleteEmpty,
      .help = N_("command to run")
     },
     {.name = NULL}
diff --git a/tools/virsh-network.c b/tools/virsh-network.c
index 3fd22db2b0..2e9613e01b 100644
--- a/tools/virsh-network.c
+++ b/tools/virsh-network.c
@@ -325,6 +325,7 @@ static const vshCmdOptDef opts_network_desc[] = {
     {.name = "new-desc",
      .type = VSH_OT_ARGV,
      .positional = true,
+     .completer = vshCompleteEmpty,
      .help = N_("message")
     },
     {.name = NULL}