From: Dan Carpenter Date: Wed, 22 Apr 2020 09:22:55 +0000 (+0300) Subject: ALSA: usb-audio: Fix a limit check in proc_dump_substream_formats() X-Git-Tag: v5.8-rc1~151^2~69 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8137d2763bf77d68babb38a7323c5152c945f20e;p=thirdparty%2Flinux.git ALSA: usb-audio: Fix a limit check in proc_dump_substream_formats() This should be ARRAY_SIZE() instead of sizeof(). The sizeof() limit is too high so it doesn't work. Fixes: 093b8494f299 ("ALSA: usb-audio: Print more information in stream proc files") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20200422092255.GB195357@mwanda Signed-off-by: Takashi Iwai --- diff --git a/sound/usb/proc.c b/sound/usb/proc.c index 5a36e192ebb00..889c550c9f297 100644 --- a/sound/usb/proc.c +++ b/sound/usb/proc.c @@ -140,7 +140,7 @@ static void proc_dump_substream_formats(struct snd_usb_substream *subs, struct s snd_iprintf(buffer, " Channel map:"); for (c = 0; c < map->channels; c++) { - if (map->map[c] >= sizeof(channel_labels) || + if (map->map[c] >= ARRAY_SIZE(channel_labels) || !channel_labels[map->map[c]]) snd_iprintf(buffer, " --"); else