From: Abdul Rahim Date: Wed, 9 Oct 2024 23:05:58 +0000 (+0530) Subject: asus-laptop: prefer strscpy() over strcpy() X-Git-Tag: v6.13-rc1~147^2~65 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8150408bfdb2f9c17970295427cf91470189e6d0;p=thirdparty%2Fkernel%2Flinux.git asus-laptop: prefer strscpy() over strcpy() The function strcpy() is depreciated and potentially unsafe. It performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. The safe replacement is strscpy() [1]. this fixes checkpatch warning: WARNING: Prefer strscpy over strcpy Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] Signed-off-by: Abdul Rahim Reviewed-by: Luke D. Jones Reviewed-by: Hans de Goede Link: https://lore.kernel.org/r/20241009230558.51892-1-abdul.rahim@myyahoo.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen --- diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 9d7e6b712abf1..d460dd194f196 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86/asus-laptop.c @@ -1832,8 +1832,8 @@ static int asus_acpi_add(struct acpi_device *device) if (!asus) return -ENOMEM; asus->handle = device->handle; - strcpy(acpi_device_name(device), ASUS_LAPTOP_DEVICE_NAME); - strcpy(acpi_device_class(device), ASUS_LAPTOP_CLASS); + strscpy(acpi_device_name(device), ASUS_LAPTOP_DEVICE_NAME); + strscpy(acpi_device_class(device), ASUS_LAPTOP_CLASS); device->driver_data = asus; asus->device = device;