From: Thorsten Blum <thorsten.blum@linux.dev>
Date: Thu, 14 Aug 2025 18:05:14 +0000 (+0200)
Subject: net: Space: Replace memset(0) + strscpy() with strscpy_pad()
X-Git-Tag: v6.18-rc1~132^2~408
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8159572936392b514e404bab2d60e47cebd5acfe;p=thirdparty%2Fkernel%2Fstable.git

net: Space: Replace memset(0) + strscpy() with strscpy_pad()

Replace memset(0) followed by strscpy() with strscpy_pad() to improve
netdev_boot_setup_add(). This avoids zeroing the memory before copying
the string and ensures the destination buffer is only written to once,
simplifying the code and improving efficiency.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250814180514.251000-2-thorsten.blum@linux.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/drivers/net/Space.c b/drivers/net/Space.c
index dc50797a2ed05..c01e2c2f7d6c7 100644
--- a/drivers/net/Space.c
+++ b/drivers/net/Space.c
@@ -67,8 +67,7 @@ static int netdev_boot_setup_add(char *name, struct ifmap *map)
 	s = dev_boot_setup;
 	for (i = 0; i < NETDEV_BOOT_SETUP_MAX; i++) {
 		if (s[i].name[0] == '\0' || s[i].name[0] == ' ') {
-			memset(s[i].name, 0, sizeof(s[i].name));
-			strscpy(s[i].name, name, IFNAMSIZ);
+			strscpy_pad(s[i].name, name);
 			memcpy(&s[i].map, map, sizeof(s[i].map));
 			break;
 		}