From: Moshe Shemesh Date: Sun, 20 Nov 2022 08:36:52 +0000 (+0200) Subject: devlink: remove redundant health state set to error X-Git-Tag: v6.2-rc1~99^2~143 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=815bc3ac75e9e34727f8ca78380266f34a3b6c66;p=thirdparty%2Flinux.git devlink: remove redundant health state set to error Reporter health_state is set twice to error in devlink_health_report(). Remove second time as it is redundant. Signed-off-by: Moshe Shemesh Reviewed-by: Eran Ben Elisha Reviewed-by: Leon Romanovsky Link: https://lore.kernel.org/r/1668933412-5498-1-git-send-email-moshe@nvidia.com Signed-off-by: Jakub Kicinski --- diff --git a/net/core/devlink.c b/net/core/devlink.c index d93bc95cd7cb8..cea154ddce7aa 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -7846,8 +7846,6 @@ int devlink_health_report(struct devlink_health_reporter *reporter, return -ECANCELED; } - reporter->health_state = DEVLINK_HEALTH_REPORTER_STATE_ERROR; - if (reporter->auto_dump) { mutex_lock(&reporter->dump_lock); /* store current dump of current error, for later analysis */