From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Date: Tue, 17 Dec 2024 07:48:03 +0000 (+0100)
Subject: gdbserver: check for nullptr condition in regcache::get_register_status
X-Git-Tag: gdb-16-branchpoint~74
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=81b65d86956f1f47cf7d45cd58d9ca849fe8ffc6;p=thirdparty%2Fbinutils-gdb.git

gdbserver: check for nullptr condition in regcache::get_register_status

A regcache can be initialized with a register value buffer, in which
case, the register_status pointer is null.  This condition is checked
in set_register_status, but not in get_register_status.  Do this check
for consistence and safety.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
---

diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc
index 583b5624333..4a064f6374b 100644
--- a/gdbserver/regcache.cc
+++ b/gdbserver/regcache.cc
@@ -526,7 +526,10 @@ regcache::get_register_status (int regnum) const
 {
 #ifndef IN_PROCESS_AGENT
   gdb_assert (regnum >= 0 && regnum < tdesc->reg_defs.size ());
-  return (enum register_status) (register_status[regnum]);
+  if (register_status != nullptr)
+    return (enum register_status) (register_status[regnum]);
+  else
+    return REG_VALID;
 #else
   return REG_VALID;
 #endif