From: Andy Shevchenko Date: Mon, 17 Mar 2025 21:29:47 +0000 (+0200) Subject: relay: use kasprintf() instead of fixed buffer formatting X-Git-Tag: v6.15-rc1~80^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=81ca2970b770d967f64803eff6e7016a68802da3;p=thirdparty%2Fkernel%2Flinux.git relay: use kasprintf() instead of fixed buffer formatting Improve readability and maintainability by replacing a hard coded string allocation and formatting by using the kasprintf() helper. It also eliminates the GCC compiler warning (with CONFIG_WERROR=y, which is default, it becomes an error: kernel/relay.c:357:42: error: `snprintf' output may be truncated before the last format character [-Werror=format-truncation=] Link: https://lkml.kernel.org/r/20250317212948.1811176-1-andriy.shevchenko@linux.intel.com Signed-off-by: Andy Shevchenko Signed-off-by: Andrew Morton --- diff --git a/kernel/relay.c b/kernel/relay.c index a8ae436dc77e5..5ac7e711e4b65 100644 --- a/kernel/relay.c +++ b/kernel/relay.c @@ -351,10 +351,9 @@ static struct dentry *relay_create_buf_file(struct rchan *chan, struct dentry *dentry; char *tmpname; - tmpname = kzalloc(NAME_MAX + 1, GFP_KERNEL); + tmpname = kasprintf(GFP_KERNEL, "%s%d", chan->base_filename, cpu); if (!tmpname) return NULL; - snprintf(tmpname, NAME_MAX, "%s%d", chan->base_filename, cpu); /* Create file in fs */ dentry = chan->cb->create_buf_file(tmpname, chan->parent,