From: Greg Kroah-Hartman Date: Tue, 18 Jan 2022 09:27:35 +0000 (+0100) Subject: 4.19-stable patches X-Git-Tag: v5.16.2~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=81f78f3013f1ae58dea6bfbcc777769180222e91;p=thirdparty%2Fkernel%2Fstable-queue.git 4.19-stable patches added patches: alsa-hda-realtek-fix-silent-output-on-gigabyte-x570-aorus-master-after-reboot-from-windows.patch --- diff --git a/queue-4.19/alsa-hda-realtek-fix-silent-output-on-gigabyte-x570-aorus-master-after-reboot-from-windows.patch b/queue-4.19/alsa-hda-realtek-fix-silent-output-on-gigabyte-x570-aorus-master-after-reboot-from-windows.patch new file mode 100644 index 00000000000..ee0a568ba27 --- /dev/null +++ b/queue-4.19/alsa-hda-realtek-fix-silent-output-on-gigabyte-x570-aorus-master-after-reboot-from-windows.patch @@ -0,0 +1,105 @@ +From c1933008679586b20437280463110c967d66f865 Mon Sep 17 00:00:00 2001 +From: Christian Lachner +Date: Mon, 3 Jan 2022 15:05:17 +0100 +Subject: ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows + +From: Christian Lachner + +commit c1933008679586b20437280463110c967d66f865 upstream. + +This patch addresses an issue where after rebooting from Windows into Linux +there would be no audio output. + +It turns out that the Realtek Audio driver on Windows changes some coeffs +which are not being reset/reinitialized when rebooting the machine. As a +result, there is no audio output until these coeffs are being reset to +their initial state. This patch takes care of that by setting known-good +(initial) values to the coeffs. + +We initially relied upon alc1220_fixup_clevo_p950() to fix some pins in the +connection list. However, it also sets coef 0x7 which does not need to be +touched. Furthermore, to prevent mixing device-specific quirks I introduced +a new alc1220_fixup_gb_x570() which is heavily based on +alc1220_fixup_clevo_p950() but does not set coeff 0x7 and fixes the coeffs +that are actually needed instead. + +This new alc1220_fixup_gb_x570() is believed to also work for other boards, +like the Gigabyte X570 Aorus Extreme and the newer Gigabyte Aorus X570S +Master. However, as there is no way for me to test these I initially only +enable this new behaviour for the mainboard I have which is the Gigabyte +X570(non-S) Aorus Master. + +I tested this patch on the 5.15 branch as well as on master and it is +working well for me. + +BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205275 +Signed-off-by: Christian Lachner +Fixes: 0d45e86d2267d ("ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master") +Cc: +Link: https://lore.kernel.org/r/20220103140517.30273-2-gladiac@gmail.com +Signed-off-by: Takashi Iwai +Signed-off-by: Greg Kroah-Hartman +--- + sound/pci/hda/patch_realtek.c | 30 +++++++++++++++++++++++++++++- + 1 file changed, 29 insertions(+), 1 deletion(-) + +--- a/sound/pci/hda/patch_realtek.c ++++ b/sound/pci/hda/patch_realtek.c +@@ -1910,6 +1910,7 @@ enum { + ALC887_FIXUP_ASUS_BASS, + ALC887_FIXUP_BASS_CHMAP, + ALC1220_FIXUP_GB_DUAL_CODECS, ++ ALC1220_FIXUP_GB_X570, + ALC1220_FIXUP_CLEVO_P950, + ALC1220_FIXUP_CLEVO_PB51ED, + ALC1220_FIXUP_CLEVO_PB51ED_PINS, +@@ -2099,6 +2100,29 @@ static void alc1220_fixup_gb_dual_codecs + } + } + ++static void alc1220_fixup_gb_x570(struct hda_codec *codec, ++ const struct hda_fixup *fix, ++ int action) ++{ ++ static const hda_nid_t conn1[] = { 0x0c }; ++ static const struct coef_fw gb_x570_coefs[] = { ++ WRITE_COEF(0x1a, 0x01c1), ++ WRITE_COEF(0x1b, 0x0202), ++ WRITE_COEF(0x43, 0x3005), ++ {} ++ }; ++ ++ switch (action) { ++ case HDA_FIXUP_ACT_PRE_PROBE: ++ snd_hda_override_conn_list(codec, 0x14, ARRAY_SIZE(conn1), conn1); ++ snd_hda_override_conn_list(codec, 0x1b, ARRAY_SIZE(conn1), conn1); ++ break; ++ case HDA_FIXUP_ACT_INIT: ++ alc_process_coef_fw(codec, gb_x570_coefs); ++ break; ++ } ++} ++ + static void alc1220_fixup_clevo_p950(struct hda_codec *codec, + const struct hda_fixup *fix, + int action) +@@ -2401,6 +2425,10 @@ static const struct hda_fixup alc882_fix + .type = HDA_FIXUP_FUNC, + .v.func = alc1220_fixup_gb_dual_codecs, + }, ++ [ALC1220_FIXUP_GB_X570] = { ++ .type = HDA_FIXUP_FUNC, ++ .v.func = alc1220_fixup_gb_x570, ++ }, + [ALC1220_FIXUP_CLEVO_P950] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc1220_fixup_clevo_p950, +@@ -2503,7 +2531,7 @@ static const struct snd_pci_quirk alc882 + SND_PCI_QUIRK(0x13fe, 0x1009, "Advantech MIT-W101", ALC886_FIXUP_EAPD), + SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE), + SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS), +- SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP_CLEVO_P950), ++ SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP_GB_X570), + SND_PCI_QUIRK(0x1458, 0xa0ce, "Gigabyte X570 Aorus Xtreme", ALC1220_FIXUP_CLEVO_P950), + SND_PCI_QUIRK(0x1462, 0x11f7, "MSI-GE63", ALC1220_FIXUP_CLEVO_P950), + SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950), diff --git a/queue-4.19/series b/queue-4.19/series index 3ccf98a99f4..75f3709cf3b 100644 --- a/queue-4.19/series +++ b/queue-4.19/series @@ -18,3 +18,4 @@ rtlwifi-rtl8192cu-fix-warning-when-calling-local_irq_restore-with-interrupts-ena firmware-qemu_fw_cfg-fix-sysfs-information-leak.patch firmware-qemu_fw_cfg-fix-null-pointer-deref-on-duplicate-entries.patch firmware-qemu_fw_cfg-fix-kobject-leak-in-probe-error-path.patch +alsa-hda-realtek-fix-silent-output-on-gigabyte-x570-aorus-master-after-reboot-from-windows.patch