From: Tomas Mraz Date: Mon, 1 Mar 2021 15:14:30 +0000 (+0100) Subject: Remove todos in decode_der2key.c and decode_ms2key.c X-Git-Tag: openssl-3.0.0-alpha13~76 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=81f9af3460dca0fe37d3a240cb385efbf0f0d362;p=thirdparty%2Fopenssl.git Remove todos in decode_der2key.c and decode_ms2key.c Those TODOs do not really apply to 3.0 as the legacy internal keys will stay. Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/14367) --- diff --git a/providers/implementations/encode_decode/decode_der2key.c b/providers/implementations/encode_decode/decode_der2key.c index fed30bf9520..09601fc335e 100644 --- a/providers/implementations/encode_decode/decode_der2key.c +++ b/providers/implementations/encode_decode/decode_der2key.c @@ -339,7 +339,7 @@ static int der2key_decode(void *vctx, OSSL_CORE_BIO *cin, int selection, * Tear out the low-level key pointer from the pkey, * but only if it matches the expected key type. * - * TODO: The check should be done with EVP_PKEY_is_a(), but + * The check should be done with EVP_PKEY_is_a(), but * as long as we still have #legacy internal keys, it's safer * to use the type numbers inside the provider. */ diff --git a/providers/implementations/encode_decode/decode_ms2key.c b/providers/implementations/encode_decode/decode_ms2key.c index 339b347fa02..e1741f4e537 100644 --- a/providers/implementations/encode_decode/decode_ms2key.c +++ b/providers/implementations/encode_decode/decode_ms2key.c @@ -148,7 +148,7 @@ static int ms2key_post(struct ms2key_ctx_st *ctx, EVP_PKEY *pkey, * Tear out the low-level key pointer from the pkey, * but only if it matches the expected key type. * - * TODO(3.0): The check should be done with EVP_PKEY_is_a(), but + * The check should be done with EVP_PKEY_is_a(), but * as long as we still have #legacy internal keys, it's safer to * use the type numbers in side the provider. */