From: Nikola Pajkovsky <nikolap@openssl.org>
Date: Thu, 10 Jul 2025 07:48:15 +0000 (+0200)
Subject: Make the lock in CRYPTO_secure_actual_size a read lock
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8253b58d60eec11fdb5e5dbf9cc61f78a9b7095d;p=thirdparty%2Fopenssl.git

Make the lock in CRYPTO_secure_actual_size a read lock

there is no operations within critical section that would
require write lock.

Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28014)
---

diff --git a/crypto/mem_sec.c b/crypto/mem_sec.c
index b8489607ffa..c47754f5099 100644
--- a/crypto/mem_sec.c
+++ b/crypto/mem_sec.c
@@ -278,7 +278,7 @@ size_t CRYPTO_secure_actual_size(void *ptr)
 #ifndef OPENSSL_NO_SECURE_MEMORY
     size_t actual_size;
 
-    if (!CRYPTO_THREAD_write_lock(sec_malloc_lock))
+    if (!CRYPTO_THREAD_read_lock(sec_malloc_lock))
         return 0;
     actual_size = sh_actual_size(ptr);
     CRYPTO_THREAD_unlock(sec_malloc_lock);